[libcxx-commits] [libcxxabi] [libcxxabi][ItaniumDemangle] Demangle explicitly named object parameters (PR #72881)

Michael Buch via libcxx-commits libcxx-commits at lists.llvm.org
Thu Nov 23 06:05:18 PST 2023


================
@@ -5424,6 +5435,9 @@ Node *AbstractManglingParser<Derived, Alloc>::parseEncoding() {
         return nullptr;
       Names.push_back(Ty);
     } while (!IsEndOfEncoding() && look() != 'Q');
+    // Ignore the explicit 'this' parameter.
+    if (NameInfo.HasExplicitObjectParameter)
----------------
Michael137 wrote:

No particular reason apart from implementation simplicity. Thinking about it some more though, we would be losing the ref-qualifiers on the functions here because in the explicit-object-paramter case that information is encoded into the parameter itself, which we discard.

Should'nt be too difficult to amend this patch to explicitly name the parameter. Probably with a `this` prefix.

https://github.com/llvm/llvm-project/pull/72881


More information about the libcxx-commits mailing list