[libcxx-commits] [libcxx] Adds back special-case for booleans in std::variant gated by _LIBCPP_ENABLE_NARROWING_CONVERSIONS_IN_VARIANT. (PR #73121)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Wed Nov 22 10:46:01 PST 2023


ldionne wrote:

Oh my, I just noticed that `_LIBCPP_ENABLE_NARROWING_CONVERSIONS_IN_VARIANT` is already a "temporary" workaround that was checked in 4 years ago to work around Google breakage. That's not great and that's amongst the reasons why we push back against one-offs like this.

Anyway, we'll honor `_LIBCPP_ENABLE_NARROWING_CONVERSIONS_IN_VARIANT` until we branch for LLVM 19 and then we'll remove all instances of that workaround, including the 4 years old one.

https://github.com/llvm/llvm-project/pull/73121


More information about the libcxx-commits mailing list