[libcxx-commits] [libcxx] [libc++][test][msan] Fix bots after #67799 (PR #73152)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Wed Nov 22 10:21:13 PST 2023


ldionne wrote:

The concern I have with disabling these tests as done in this patch is that it'll disable it for our CI as well, where these tests are running fine. And there's a lot of value in having these tests run under msan and tsan due to their nature. I can see that the tests are clearly super slow on your bot, I am just not certain what's the best way to address this without removing a lot of coverage for everyone else.

Unrelated question: what additional coverage do your bots provide on top of the testing we already do with sanitizers? As a general guideline, libc++ doesn't support CI setups outside of our own pre-commit CI, because it leads to these kinds of difficulties where we don't control the setup.

https://github.com/llvm/llvm-project/pull/73152


More information about the libcxx-commits mailing list