[libcxx-commits] [libcxx] [libc++] Floating Point Atomic (PR #67799)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Wed Nov 22 10:14:26 PST 2023


ldionne wrote:

> @huixie90 it's landed breaking msan tsan even presubmit failed them "37 of 40 checks passed"

Hmm, I just looked and the `msan` timeouts are unrelated to this patch (we're having some trouble right now):

```
********************
Timed Out Tests (2):
  llvm-libc++-shared.cfg.in :: std/containers/sequences/deque/deque.modifiers/insert_iter_iter.pass.cpp
  llvm-libc++-shared.cfg.in :: std/numerics/rand/rand.dist/rand.dist.bern/rand.dist.bern.negbin/eval.pass.cpp
```

The `tsan` failures are more mysterious, but it looks like maybe the job as a whole timed out (which could be due to this patch or not): https://github.com/llvm/llvm-project/actions/runs/6933781778/job/18867566743?pr=67799

So I'm not certain @huixie90 bypassed any checks he should not have bypassed due to ongoing flakes as part of merging this. I'm not claiming this means those tests aren't broken on tsan/msan, I'm just saying the information we have with the checks on this patch doesn't allow claiming that.

https://github.com/llvm/llvm-project/pull/67799


More information about the libcxx-commits mailing list