[libcxx-commits] [libcxx] [FIX] Fix the function 'isctype' failed in arm64-big-endian (PR #73070)

[via libcxx-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: None (W-50243)

<details>
<summary>Changes</summary>

 Thefunction `isctype` fails in `arm64-big-endian` while succeeds in `arm64-little-endian`. Because big-endian or little-endian determines the byte order of the character mask obtained by isctype, while __regex_word of the corresponding obtained type mask does not change accordingly.
 I found the relevant changes:[D17132](https://reviews.llvm.org/D17132l), In this changes, the value of __regex_word is determined by whether the GLIBC is defined to determine whether the value is big-endian. However, GLIBC now is defined in arm64-little-endian and arm64-big-endian, but mips is not defined. This results in __regex_word being the same in the both sides. So I added a macro after mips to judge.


---
Full diff: https://github.com/llvm/llvm-project/pull/73070.diff


1 Files Affected:

- (modified) libcxx/include/__locale (+1-1) 


``````````diff
diff --git a/libcxx/include/__locale b/libcxx/include/__locale
index b1502dd71edadf6..874efa4789f260d 100644
--- a/libcxx/include/__locale
+++ b/libcxx/include/__locale
@@ -384,7 +384,7 @@ public:
     static const mask punct  = _ISpunct;
     static const mask xdigit = _ISxdigit;
     static const mask blank  = _ISblank;
-#if defined(__mips__)
+#if defined(__mips__) || defined(__BIG_ENDIAN__)
     static const mask __regex_word = static_cast<mask>(_ISbit(15));
 #else
     static const mask __regex_word = 0x80;

``````````

</details>


https://github.com/llvm/llvm-project/pull/73070