[libcxx-commits] [libcxxabi] [libc++abi] Introduce LIBCXXABI_ENABLE_DEMANGLER (PR #72948)

[Louis Dionne via libcxx-commits]

================
@@ -385,7 +388,7 @@ if (LIBCXXABI_SILENT_TERMINATE)
   add_definitions(-DLIBCXXABI_SILENT_TERMINATE)
 endif()
 
-if (LIBCXXABI_NON_DEMANGLING_TERMINATE)
+if (LIBCXXABI_NON_DEMANGLING_TERMINATE OR NOT LIBCXXABI_ENABLE_DEMANGLER)
----------------
ldionne wrote:

I generally support adding this capability, but I'd like to avoid making this change as an "addition of complexity", and instead modify what we already have. So it seems like we already have the ability to use a non-demangling `terminate()`. This was added by @DanAlbert a few years ago. Can we merge these two options? In other words, can we instead say that you get a non-demangling terminate if-and-only-if `LIBCXXABI_ENABLE_DEMANGLER=OFF`?

If that's reasonable, then we add this option but really we're not adding much complexity since we also remove something else.

https://github.com/llvm/llvm-project/pull/72948