[libcxx-commits] [libcxx] [libc++][hardening] Categorize all `ryu` assertions as internal (PR #71853)

Konstantin Varlamov via libcxx-commits libcxx-commits at lists.llvm.org
Mon Nov 20 20:13:42 PST 2023


var-const wrote:

> > In practice, this means that we'll never enable those assertions because we'd have to build the dylib in Debug mode. Is that what we intend? It may be OK, but I wanted to point it out.
> 
> Does that differ from `_LIBCPP_ASSERT_UNCATEGORIZED` or would that be debug build only too?

"uncategorized" assertions are essentially TODOs. They are currently enabled in the `extensive` mode to avoid a significant change in behavior for current users of the safe mode. Once the existing uncategorized assertions get properly classified, I think we should switch to only enabling "uncategorized" in the debug mode (we could get rid of this category entirely but realistically it might be useful to avoid blocking patches on categorization in cases where it's not obvious).

https://github.com/llvm/llvm-project/pull/71853


More information about the libcxx-commits mailing list