[libcxx-commits] [libcxx] [libc++][NFC] Use __construct_at and __destroy_at insted of using preprocessor conditionals (PR #70866)
via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Nov 20 17:22:05 PST 2023
================
@@ -300,11 +300,7 @@ struct _LIBCPP_TEMPLATE_VIS allocator_traits
__enable_if_t<!__has_construct<allocator_type, _Tp*, _Args...>::value> >
_LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX20
static void construct(allocator_type&, _Tp* __p, _Args&&... __args) {
-#if _LIBCPP_STD_VER >= 20
----------------
EricWF wrote:
Same question as below.
Are we required to use `construct_at` here? If not, it seems to be more expensive, and causes arguably poorer diagnostic messages.
https://github.com/llvm/llvm-project/pull/70866
More information about the libcxx-commits
mailing list