[libcxx-commits] [libcxx] [libc++] Don't open-close namespace std in __config (PR #72695)

via libcxx-commits libcxx-commits at lists.llvm.org
Fri Nov 17 11:56:12 PST 2023


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-libcxx

Author: Louis Dionne (ldionne)

<details>
<summary>Changes</summary>

This doesn't seem necessary and it is just kind of weird to do that in __config, so remove it.

---
Full diff: https://github.com/llvm/llvm-project/pull/72695.diff


1 Files Affected:

- (modified) libcxx/include/__config (-2) 


``````````diff
diff --git a/libcxx/include/__config b/libcxx/include/__config
index e8da358bb8d7cd5..90e23dbdd8622b5 100644
--- a/libcxx/include/__config
+++ b/libcxx/include/__config
@@ -836,8 +836,6 @@ typedef __char32_t char32_t;
 #  define _LIBCPP_END_NAMESPACE_STD }}
 #  define _VSTD std
 
-_LIBCPP_BEGIN_NAMESPACE_STD _LIBCPP_END_NAMESPACE_STD
-
 #  if _LIBCPP_STD_VER >= 17
 #    define _LIBCPP_BEGIN_NAMESPACE_FILESYSTEM                                                                         \
        _LIBCPP_BEGIN_NAMESPACE_STD inline namespace __fs { namespace filesystem {

``````````

</details>


https://github.com/llvm/llvm-project/pull/72695


More information about the libcxx-commits mailing list