[libcxx-commits] [libcxx] [ASan][libc++] std::basic_string annotations (PR #72677)

[via libcxx-commits]

AdvenamTacet wrote:

@ldionne Given that the requirement for sanitized libc++ and libc++abi is already an established practice (Memory Sanitizer), could we proceed with merging this branch after addressing all code review concerns, prior to developing a unified approach for shipping instrumented libraries?

Maintaining this patch outside of upstream takes a lot of time due to fact how many files/functions are modified across the codebase. Each refactor/update/change of names on upstream requires dealing with merge conflicts because of that. Occasionally, identifying issues proves challenging without a thorough examination of all changes. Sometimes it's just hard to notice, unlucky conflict resolving problem. For instance, I recently spent hours fighting an issue caused by "auto resolving conflicts" duplicating a line of code, which resulted in difficult-to-detect undefined behavior. I would love to spend more time on developing something valuable for LLVM instead of maintaining the patch outside of upstream.

https://github.com/llvm/llvm-project/pull/72677