[libcxx-commits] [libcxx] [libc++] Fixes lit portability issues. (PR #72435)

[Mark de Wever via libcxx-commits]

================
@@ -29,7 +29,13 @@ def appendToSubstitution(substitutions, key, value):
     return [(k, v + " " + value) if k == key else (k, v) for (k, v) in substitutions]
 
 
-std = getSubstitution("%{cxx_std}", config)
+# External users of the LLVM test suite might not have set the substitutions.
+std = ""
+try:
+    std = getSubstitution("%{cxx_std}", config)
+except:
+    pass
----------------
mordante wrote:

@philnik777 Your suggestion changes the scope of `std`, which means the code no longer works. (In general I agree that your suggestion is the typical way to write it.)

@ldionne I was not sure we required all substitutions. AFAIK they are not documented and changes to them not mentioned in the release notes. I'll undo the changes to this file.

https://github.com/llvm/llvm-project/pull/72435