[libcxx-commits] [libcxx] [libc++] Remove outdated _LIBCPP_CLANG_VER check (PR #71759)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Thu Nov 9 11:08:41 PST 2023


ldionne wrote:

> LGTM, but I would also remove the comment after one line `#if`.
> 
> We can already update `_LIBCPP_CLANG_VER` in one more place to already warn about incompatibility when someone is using something unsupported.
> 
> https://github.com/llvm/llvm-project/blob/b44399296a7fa4323ab32739df6dbcfc6068af8f/libcxx/include/__config#L36-L42
> 
> I'm unsure how `_LIBCPP_APPLE_CLANG_VER` works, so I don't know if it can be already updated, but I guess so.

I'll do that in a separate patch, good catch though.

https://github.com/llvm/llvm-project/pull/71759


More information about the libcxx-commits mailing list