[libcxx-commits] [libcxxabi] [libcxxabi] Remove reference to Type::getInt8PtrTy; NFC (PR #71569)

Paulo Matos via libcxx-commits libcxx-commits at lists.llvm.org
Wed Nov 8 23:40:37 PST 2023


pmatos wrote:

> This is a test for the demangler which uses a bunch of symbols taken from the monorepo. Whether that function actually still exists or not in the LLVM tree is not relevant to the test, so I think this patch is not necessary. This is a common misconception BTW, it's kind of annoying that we have exactly the same names in the demangler tests because it causes confusion like this when people grep throughout the whole monorepo.
> 
> I'll close this but please comment and reopen if you disagree.

I know nothing about libcxxapi. If you tell me that the patch is unnecessary, I trust you. :) Thanks for closing and the explanation.

https://github.com/llvm/llvm-project/pull/71569


More information about the libcxx-commits mailing list