[libcxx-commits] [PATCH] D154246: [libc++] Add check for building with picolibc

Tue Nov 7 06:56:34 PST 2023

domin144 marked 3 inline comments as done.
domin144 added a comment.

The gcc-13 error in "has-64-bit-atomics" detection is:

  /home/domwoj01/sources/llvm-project/builds/libcxx-gcc-13-test/build/include/c++/v1/limits:529:69: error: ‘float_denorm_style’ is deprecated [-Werror=deprecated-declarations]
    529 |     _LIBCPP_CONSTEXPR const float_denorm_style numeric_limits<_Tp>::has_denorm;
        |                                                                     ^~~~~~~~~~

The tests are run with the flag below, while the "has-64-bit-atomics" are not.

  AddCompileFlag("-D_LIBCPP_DISABLE_DEPRECATION_WARNINGS"),

I moved the "has-64-bit-atomics" check to the end, so it also gets the flag.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154246/new/

https://reviews.llvm.org/D154246