[libcxx-commits] [libcxx] [libcxx] Make `libc++` formatting build bot print necessary changes to pass (PR #71237)
Louis Dionne via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Nov 6 23:16:41 PST 2023
ldionne wrote:
These comments normally contain a drop-down arrow that includes the diff you'd need to apply in order to fix the clang-format bot.
<img width="915" alt="Screenshot 2023-11-06 at 21 13 31" src="https://github.com/llvm/llvm-project/assets/700834/b4ea128b-e9d8-4b2d-a2c8-410d840bb8c1">
The reason why I'm lukewarm to this patch is that it duplicates work that is already done in the other clang-format job, and it also makes it less clear which job is responsible for what. I actually think that we could solve the issue we're having here if we instead moved the checking of `ignore_format.txt` to the clang-format GitHub action. Then everything related to clang-format would be in the same place, the generated-files check would fail far less often and when it does it would be really clear why. WDYT?
https://github.com/llvm/llvm-project/pull/71237
More information about the libcxx-commits
mailing list