[libcxx-commits] [clang-tools-extra] [libc] [libcxx] [compiler-rt] [flang] [mlir] [clang] [llvm] [mlir][spirv] Implement gpu::TargetAttrInterface (PR #69949)

[Fabian Mora via libcxx-commits]

================
@@ -15,6 +15,7 @@
 
 #include "Utils.h"
 #include "mlir/Dialect/GPU/IR/GPUDialect.h"
+#include "mlir/Dialect/SPIRV/IR/SPIRVAttributes.h"
----------------
fabianmcg wrote:

Back when the compilation redesign was happening we decided to add the attach* passes in GPU to avoid polluting lower level dialects with GPU includes. However, I do agree that include shouldn't be there, as far as I could tell, that include is only needed by one pass option `mlir::spirv::TargetEnvAttr::kUnknownDeviceID`, so it should be possible to remove it. I'll fix it.

https://github.com/llvm/llvm-project/pull/69949