[libcxx-commits] [libcxx] [libcxx] Make `libc++` formatting build bot print necessary changes to pass (PR #71237)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Fri Nov 3 14:54:12 PDT 2023


ldionne wrote:

The `Check code formatting / code_formatter ` GitHub Actions job already prints that diff, I think. Is your patch doing something different?

I do agree it's kind of confusing that the generated files job is the one checking for `ignore_format.txt` -- maybe we don't need to check for that at all. After all, if you mis-format a file the `clang-format` job will tell you, and if you forget to remove something from the `ignore_format.txt` list then it's not really a big deal.

https://github.com/llvm/llvm-project/pull/71237


More information about the libcxx-commits mailing list