[libcxx-commits] [PATCH] D157298: [RFC][libc++] Reduce the size of translation units

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

I was really excited about this when I saw the numbers initially. However, the benefits of this patch seem to go down very drastically after C++20, so I am left a bit unsure whether it's worth making this wide-ranging change in libc++. Indeed, we want to push our users to newer standard versions -- for example Clang now defaults to C++17, and eventually will default to C++20. In light of this, I am not sure it is worth shuffling around so much code for a benefit that will go away. Instead, I think the most reliable way of solving compilation time issues is going to be for users to adopt modules. I know this is a really frustrating answer to a lot of people, but concretely that's what WG21 is pushing people towards. For example, when they specify that `<vector>` should include `<format>`, they are thinking "yeah users will use modules anyway", otherwise they would make different design choices. So basically I think we might be fighting against the current if we try to optimize build times this way instead.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157298/new/

https://reviews.llvm.org/D157298