[libcxx-commits] [PATCH] D112152: [libc++] Unroll loop in std::find_if and define other std::find variants in terms of it

[Louis Dionne via Phabricator via libcxx-commits]

ldionne abandoned this revision.
ldionne added a comment.
Herald added a subscriber: StephenFan.
Herald added a project: All.

I am going to abandon this patch. After consideration, I do not think that manually unrolling `std::find_if` like this is the way to go. Indeed, this leads to much worse code size and we really shouldn't be doing these kinds of optimizations manually, instead the compiler should learn to do it. Also, since this patch was created, we've improved `std::find` so that it calls `memchr` when it can, which is even better for both code size and speed.

I'll rebase the test improvements on top of `main` and upload a patch on GitHub though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112152/new/

https://reviews.llvm.org/D112152