[libcxx-commits] [libcxxabi] [libcxx] [libc++] Bump the C++ Standard used to compile the dylib to C++23 (PR #66824)
Louis Dionne via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Nov 3 07:43:26 PDT 2023
================
@@ -37,7 +37,7 @@ set(Clang_DIR "${Clang_DIR_SAVE}" CACHE PATH "The directory containing a CMake c
message(STATUS "Found system-installed LLVM ${LLVM_PACKAGE_VERSION} with headers in ${LLVM_INCLUDE_DIRS}")
-set(CMAKE_CXX_STANDARD 20)
+set(CMAKE_CXX_STANDARD 23)
----------------
ldionne wrote:
I would expect this to use the compiler chosen with `CMAKE_CXX_COMPILER` and its associated library as well. Which on Linux is going to be libstdc++ usually, regardless of whether `CMAKE_CXX_COMPILER` is Clang or GCC. I think that's fine. It's a bit concerning that GCC 13 doesn't seem to accept libstdc++'s `<ranges>` header when `-std=c++23` is passed but I guess that's separate. I'll revert this part of the patch simply because it will help unblock the patch by fixing some of the CI, and concretely it's not critical to be building the Clang tidy checks with the latest Standard mode.
https://github.com/llvm/llvm-project/pull/66824
More information about the libcxx-commits
mailing list