[libcxx-commits] [PATCH] D132509: [libc++] Use _Lazy in tuple constructors

Fri Nov 3 05:21:06 PDT 2023

mstorsjo added a comment.

In D132509#4656084 <https://reviews.llvm.org/D132509#4656084>, @philnik wrote:

> In D132509#4656075 <https://reviews.llvm.org/D132509#4656075>, @mstorsjo wrote:
>
>> FYI, I see that this change had the effect, that compiling `std/utilities/tuple/tuple.tuple/tuple.cnstr/recursion_depth.pass.cpp` now uses 2.3 GB of memory in Clang, while it previously only used 200 MB memory to compile it.
>>
>> I guess that particular testcase is a rather extreme case, but I just wanted to doublecheck that this was expected behaviour.
>
> Did the test changes affect the memory usage or the code changes?

Good point. It looks like this was caused by the test change, not by the header itself.

The old test file together with the new header uses the same amount of memory to compile as before.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132509/new/

https://reviews.llvm.org/D132509