[libcxx-commits] [libcxx] [libc++] add floating point type check for uniform real distrubtion (PR #70564)

[Nhat Nguyen via libcxx-commits]

NhatNguyen1810 wrote:

> @NhatNguyen1810 you can see error report by clicking details next to the buildkite and then on the job which failed. It looks like your code works with GCC only. You can find details here: https://buildkite.com/llvm-project/libcxx-ci/builds/31338#018b8dda-3da3-4049-af36-d3bbe1bf054c
> 
> `FAIL: llvm-libc++-shared.cfg.in :: libcxx/random/random.uniform.real/traits_mismatch.verify.cpp (1664 of 9610)` - that's the test which failed.
> 
> ```shell
> # .---command stderr------------
> --
>   | # \| error: 'expected-error' diagnostics seen but not expected:
>   | # \|   File /home/libcxx-builder/.buildkite-agent/builds/google-libcxx-builder-6be6c9a4344c-1/llvm-project/libcxx-ci/build/generic-cxx26/include/c++/v1/__random/uniform_real_distribution.h Line 31: static assertion failed due to requirement 'is_floating_point<int>::value': result_type must be floating type
>   | # \|   File /home/libcxx-builder/.buildkite-agent/builds/google-libcxx-builder-6be6c9a4344c-1/llvm-project/libcxx-ci/libcxx/test/libcxx/random/random.uniform.real/traits_mismatch.verify.cpp Line 20: cannot find end ('}}') of expected string
>   | # \| 2 errors generated.
>   | # `-----------------------------
> ```

Hi, thanks for answering me! Yeah I saw that error message, but I guess its an error because I have multiple lines for the error message? 

To give you more contex, originally I ran `git-clang-format`, then the CI passed the buildkite, however it failed the last step with some info about the `ignore-format.txt` file. I added the test file to the `ignore-format.txt` file and still got that error. 

@ldionne Ide
suggested me to run `clang-format` on the test file. I ran `clang-format -style=llvm` on the test file, then it became like above and the CI build breaks. Now I am not sure how to move forward. Any ideas? Thanks!!

https://github.com/llvm/llvm-project/pull/70564