[libcxx-commits] [libcxx] [libcxx][test] std::array::iterator are not pointers by C++ standard (PR #70729)

Duo Wang via libcxx-commits libcxx-commits at lists.llvm.org
Thu Nov 2 13:53:09 PDT 2023


================
@@ -60,6 +60,13 @@ static_assert(!HasMakeHeapR<UncheckedRange<const int*>>); // Doesn't satisfy `so
 
 template <std::size_t N, class T, class Iter>
 constexpr void verify_heap(const std::array<T, N>& heapified, Iter last, std::array<T, N> expected) {
+  assert(heapified == expected);
----------------
wdunicornpro wrote:

I agree that we should use pointers as much as possible for these tests. In practice, this might require a bigger rewriting of the tests. For now, I have updated `verify_heap` so that we are _eventually_ checking equality of pointers.

https://github.com/llvm/llvm-project/pull/70729


More information about the libcxx-commits mailing list