[libcxx-commits] [libcxx] [libc++][NFC] Refactor _LIBCPP_AVAILABILITY_HAS_* macros to always be defined (PR #71002)

Louis Dionne via libcxx-commits libcxx-commits at lists.llvm.org
Thu Nov 2 09:25:41 PDT 2023


================
@@ -190,15 +190,15 @@ def add_version_header(tc):
             "name": "__cpp_lib_atomic_wait",
             "values": {"c++20": 201907},
             "headers": ["atomic"],
-            "test_suite_guard": "!defined(_LIBCPP_AVAILABILITY_HAS_NO_SYNC)",
-            "libcxx_guard": "!defined(_LIBCPP_AVAILABILITY_HAS_NO_SYNC)",
+            "test_suite_guard": "!defined(_LIBCPP_AVAILABILITY_HAS_SYNC) || _LIBCPP_AVAILABILITY_HAS_SYNC",
----------------
ldionne wrote:

Like you suggested, I think `!defined(_LIBCPP_VERSION) || _LIBCPP_AVAILABILITY_HAS_SYNC` is better since it's more obvious why the check is written that way.

https://github.com/llvm/llvm-project/pull/71002


More information about the libcxx-commits mailing list