[libcxx-commits] [libcxx] [WIP][libc++] Fixes basic_streambuf instantiation. (PR #70963)

Wed Nov 1 11:36:08 PDT 2023

mordante wrote:

With Clang it fails since the change adds one new symbol
```
Symbol added: _ZNSt3__115basic_stringbufIcNS_11char_traitsIcEENS_9allocatorIcEEE7seekposENS_4fposI11__mbstate_tEEj
--
    {'name': 
'_ZNSt3__115basic_stringbufIcNS_11char_traitsIcEENS_9allocatorIcEEE7seekposENS_4fposI11__mbstate_tEEj',
 'type': 'FUNC', 'is_defined': True}
``
With GCC is fails with more symbol changes
```
Symbol added: _ZdlPvmSt11align_val_t
    {'name': '_ZdlPvmSt11align_val_t', 'type': 'FUNC', 'is_defined': False}

Symbol added: __cxa_throw_bad_array_new_length
    {'name': '__cxa_throw_bad_array_new_length', 'type': 'FUNC', 'is_defined': False}

Symbol added: _ZdlPvm
    {'name': '_ZdlPvm', 'type': 'FUNC', 'is_defined': False}

Symbol added: _ZNSt3__119__DOUBLE_POW5_SPLITE
    {'name': '_ZNSt3__119__DOUBLE_POW5_SPLITE', 'size': 5216, 'type': 'OBJECT', 'is_defined': True}

Symbol added: _ZNSt3__114__POW10_OFFSETE
    {'name': '_ZNSt3__114__POW10_OFFSETE', 'size': 128, 'type': 'OBJECT', 'is_defined': True}

Symbol added: _ZNSt3__16__itoa10__pow10_32E
    {'name': '_ZNSt3__16__itoa10__pow10_32E', 'size': 40, 'type': 'OBJECT', 'is_defined': True}

Symbol added: _ZNSt3__117__append_n_digitsEjjPc
    {'name': '_ZNSt3__117__append_n_digitsEjjPc', 'type': 'FUNC', 'is_defined': True}

Symbol added: _ZNSt3__116__POW10_OFFSET_2E
    {'name': '_ZNSt3__116__POW10_OFFSET_2E', 'size': 138, 'type': 'OBJECT', 'is_defined': True}

Symbol added: _ZNSt3__114error_categoryC1Ev
    {'name': '_ZNSt3__114error_categoryC1Ev', 'type': 'FUNC', 'is_defined': True}

Symbol added: _ZNSt3__120__d2fixed_buffered_nEPcS0_dj
    {'name': '_ZNSt3__120__d2fixed_buffered_nEPcS0_dj', 'type': 'FUNC', 'is_defined': True}

Symbol added: _ZNSt3__115basic_stringbufIcNS_11char_traitsIcEENS_9allocatorIcEEE7seekposENS_4fposI11__mbstate_tEEj
    {'name': '_ZNSt3__115basic_stringbufIcNS_11char_traitsIcEENS_9allocatorIcEEE7seekposENS_4fposI11__mbstate_tEEj', 'type': 'FUNC', 'is_defined': True}

Symbol added: _ZNSt3__125_General_precision_tablesIdE17_Ordinary_X_tableE
    {'name': '_ZNSt3__125_General_precision_tablesIdE17_Ordinary_X_tableE', 'size': 2512, 'type': 'OBJECT', 'is_defined': True}

Symbol added: _ZNSt3__118__d2exp_buffered_nEPcS0_dj
    {'name': '_ZNSt3__118__d2exp_buffered_nEPcS0_dj', 'type': 'FUNC', 'is_defined': True}

Symbol added: _ZNSt3__16__itoa10__pow10_64E
    {'name': '_ZNSt3__16__itoa10__pow10_64E', 'size': 160, 'type': 'OBJECT', 'is_defined': True}

Symbol added: _ZTVNSt3__120__time_get_c_storageIcEE
    {'name': '_ZTVNSt3__120__time_get_c_storageIcEE', 'size': 72, 'type': 'OBJECT', 'is_defined': True}

Symbol added: _ZNSt3__125_General_precision_tablesIdE16_Special_X_tableE
    {'name': '_ZNSt3__125_General_precision_tablesIdE16_Special_X_tableE', 'size': 1560, 'type': 'OBJECT', 'is_defined': True}

Symbol added: _ZNSt3__122__FLOAT_POW5_INV_SPLITE
    {'name': '_ZNSt3__122__FLOAT_POW5_INV_SPLITE', 'size': 248, 'type': 'OBJECT', 'is_defined': True}

Symbol added: _ZNSt3__123__DOUBLE_POW5_INV_SPLITE
    {'name': '_ZNSt3__123__DOUBLE_POW5_INV_SPLITE', 'size': 4672, 'type': 'OBJECT', 'is_defined': True}

Symbol added: _ZTVNSt3__120__time_get_c_storageIwEE
    {'name': '_ZTVNSt3__120__time_get_c_storageIwEE', 'size': 72, 'type': 'OBJECT', 'is_defined': True}

Symbol added: _ZNSt3__125_General_precision_tablesIfE17_Ordinary_X_tableE
    {'name': '_ZNSt3__125_General_precision_tablesIfE17_Ordinary_X_tableE', 'size': 176, 'type': 'OBJECT', 'is_defined': True}

Symbol added: _ZNSt3__110build_nameERKNS_12basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEES7_i
    {'name': '_ZNSt3__110build_nameERKNS_12basic_stringIcNS_11char_traitsIcEENS_9allocatorIcEEEES7_i', 'type': 'FUNC', 'is_defined': True}

Symbol added: _ZNSt3__125_General_precision_tablesIfE16_Special_X_tableE
    {'name': '_ZNSt3__125_General_precision_tablesIfE16_Special_X_tableE', 'size': 252, 'type': 'OBJECT', 'is_defined': True}

Symbol added: _ZNSt3__19DoIOSInitD1Ev
    {'name': '_ZNSt3__19DoIOSInitD1Ev', 'type': 'FUNC', 'is_defined': True}

Symbol added: _ZNSt3__118__FLOAT_POW5_SPLITE
    {'name': '_ZNSt3__118__FLOAT_POW5_SPLITE', 'size': 376, 'type': 'OBJECT', 'is_defined': True}

Symbol added: _ZNSt3__19DoIOSInitD2Ev
    {'name': '_ZNSt3__19DoIOSInitD2Ev', 'type': 'FUNC', 'is_defined': True}

Symbol added: _ZNSt3__120__append_nine_digitsEjPc
    {'name': '_ZNSt3__120__append_nine_digitsEjPc', 'type': 'FUNC', 'is_defined': True}

Symbol added: _ZNSt3__16__itoa16__digits_base_10E
    {'name': '_ZNSt3__16__itoa16__digits_base_10E', 'size': 200, 'type': 'OBJECT', 'is_defined': True}

Symbol added: _ZNSt3__19DoIOSInitC1Ev
    {'name': '_ZNSt3__19DoIOSInitC1Ev', 'type': 'FUNC', 'is_defined': True}

Symbol added: _ZNSt3__19DoIOSInitC2Ev
    {'name': '_ZNSt3__19DoIOSInitC2Ev', 'type': 'FUNC', 'is_defined': True}

Symbol added: _ZNSt3__16__itoa16_Charconv_digitsE
    {'name': '_ZNSt3__16__itoa16_Charconv_digitsE', 'size': 36, 'type': 'OBJECT', 'is_defined': True}

Symbol added: _ZNSt3__113__POW10_SPLITE
    {'name': '_ZNSt3__113__POW10_SPLITE', 'size': 29376, 'type': 'OBJECT', 'is_defined': True}

Symbol added: _ZNSt3__116__f2s_buffered_nEPcS0_fNS_12chars_formatE
    {'name': '_ZNSt3__116__f2s_buffered_nEPcS0_fNS_12chars_formatE', 'type': 'FUNC', 'is_defined': True}

Symbol added: _ZNSt3__115__POW10_SPLIT_2E
    {'name': '_ZNSt3__115__POW10_SPLIT_2E', 'size': 75192, 'type': 'OBJECT', 'is_defined': True}

Symbol added: _ZNSt3__116__d2s_buffered_nEPcS0_dNS_12chars_formatE
    {'name': '_ZNSt3__116__d2s_buffered_nEPcS0_dNS_12chars_formatE', 'type': 'FUNC', 'is_defined': True}

Symbol added: _ZNSt3__113__MIN_BLOCK_2E
    {'name': '_ZNSt3__113__MIN_BLOCK_2E', 'size': 69, 'type': 'OBJECT', 'is_defined': True}

SYMBOL REMOVED: _ZdlPvSt11align_val_t
    {'is_defined': False, 'name': '_ZdlPvSt11align_val_t', 'type': 'FUNC'}

SYMBOL REMOVED: _ZTCNSt3__110istrstreamE0_NS_13basic_istreamIcNS_11char_traitsIcEEEE
    {'is_defined': True, 'name': '_ZTCNSt3__110istrstreamE0_NS_13basic_istreamIcNS_11char_traitsIcEEEE', 'size': 80, 'type': 'OBJECT'}

SYMBOL REMOVED: _ZTCNSt3__110ostrstreamE0_NS_13basic_ostreamIcNS_11char_traitsIcEEEE
    {'is_defined': True, 'name': '_ZTCNSt3__110ostrstreamE0_NS_13basic_ostreamIcNS_11char_traitsIcEEEE', 'size': 80, 'type': 'OBJECT'}

SYMBOL REMOVED: _ZTCNSt3__114basic_ifstreamIcNS_11char_traitsIcEEEE0_NS_13basic_istreamIcS2_EE
    {'is_defined': True, 'name': '_ZTCNSt3__114basic_ifstreamIcNS_11char_traitsIcEEEE0_NS_13basic_istreamIcS2_EE', 'size': 80, 'type': 'OBJECT'}

SYMBOL REMOVED: _ZTCNSt3__114basic_iostreamIcNS_11char_traitsIcEEEE0_NS_13basic_istreamIcS2_EE
    {'is_defined': True, 'name': '_ZTCNSt3__114basic_iostreamIcNS_11char_traitsIcEEEE0_NS_13basic_istreamIcS2_EE', 'size': 80, 'type': 'OBJECT'}

SYMBOL REMOVED: _ZTCNSt3__114basic_iostreamIcNS_11char_traitsIcEEEE16_NS_13basic_ostreamIcS2_EE
    {'is_defined': True, 'name': '_ZTCNSt3__114basic_iostreamIcNS_11char_traitsIcEEEE16_NS_13basic_ostreamIcS2_EE', 'size': 80, 'type': 'OBJECT'}

SYMBOL REMOVED: _ZTCNSt3__114basic_ofstreamIcNS_11char_traitsIcEEEE0_NS_13basic_ostreamIcS2_EE
    {'is_defined': True, 'name': '_ZTCNSt3__114basic_ofstreamIcNS_11char_traitsIcEEEE0_NS_13basic_ostreamIcS2_EE', 'size': 80, 'type': 'OBJECT'}

SYMBOL REMOVED: _ZTCNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE0_NS_13basic_istreamIcS2_EE
    {'is_defined': True, 'name': '_ZTCNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE0_NS_13basic_istreamIcS2_EE', 'size': 80, 'type': 'OBJECT'}

SYMBOL REMOVED: _ZTCNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE0_NS_14basic_iostreamIcS2_EE
    {'is_defined': True, 'name': '_ZTCNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE0_NS_14basic_iostreamIcS2_EE', 'size': 120, 'type': 'OBJECT'}

SYMBOL REMOVED: _ZTCNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE16_NS_13basic_ostreamIcS2_EE
    {'is_defined': True, 'name': '_ZTCNSt3__118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE16_NS_13basic_ostreamIcS2_EE', 'size': 80, 'type': 'OBJECT'}

SYMBOL REMOVED: _ZTCNSt3__119basic_istringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE0_NS_13basic_istreamIcS2_EE
    {'is_defined': True, 'name': '_ZTCNSt3__119basic_istringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE0_NS_13basic_istreamIcS2_EE', 'size': 80, 'type': 'OBJECT'}

SYMBOL REMOVED: _ZTCNSt3__119basic_ostringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE0_NS_13basic_ostreamIcS2_EE
    {'is_defined': True, 'name': '_ZTCNSt3__119basic_ostringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE0_NS_13basic_ostreamIcS2_EE', 'size': 80, 'type': 'OBJECT'}

SYMBOL REMOVED: _ZTCNSt3__19strstreamE0_NS_13basic_istreamIcNS_11char_traitsIcEEEE
    {'is_defined': True, 'name': '_ZTCNSt3__19strstreamE0_NS_13basic_istreamIcNS_11char_traitsIcEEEE', 'size': 80, 'type': 'OBJECT'}

SYMBOL REMOVED: _ZTCNSt3__19strstreamE0_NS_14basic_iostreamIcNS_11char_traitsIcEEEE
    {'is_defined': True, 'name': '_ZTCNSt3__19strstreamE0_NS_14basic_iostreamIcNS_11char_traitsIcEEEE', 'size': 120, 'type': 'OBJECT'}

SYMBOL REMOVED: _ZTCNSt3__19strstreamE16_NS_13basic_ostreamIcNS_11char_traitsIcEEEE
    {'is_defined': True, 'name': '_ZTCNSt3__19strstreamE16_NS_13basic_ostreamIcNS_11char_traitsIcEEEE', 'size': 80, 'type': 'OBJECT'}

Summary
    Added:   35
    Removed: 15
    Changed: 0
```

https://github.com/llvm/llvm-project/pull/70963