[libcxx-commits] [PATCH] D140183: [libc++][Android] Disable test_no_resolve_symlink_on_symlink on Android

[Ryan Prichard via Phabricator via libcxx-commits]

rprichard added a comment.

I reported a kernel bug related to this issue, https://bugzilla.kernel.org/show_bug.cgi?id=216834.

XFAIL would remove test coverage of the rest of this test file, which I think is more interesting than what test_no_resolve_symlink_on_symlink is testing. But it should be easy to split test_no_resolve_symlink_on_symlink into its own test file?

I think the condition we want for the XFAIL today is "/data/local/tmp is on an ext4 filesystem and/or the device's API is 21 or 22". The latter could be determined using android_get_device_api_level() and added to a general feature like `android-device-api=$API`. We could determine the filesystem type by dumping and parsing `/proc/mounts`. We may have to revisit that if the kernel gets fixed in a way that fixes this test for Bionic. (IIRC, I think other libc's implement fchmodat differently, in a way that doesn't expose the kernel behavior.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140183/new/

https://reviews.llvm.org/D140183