[libcxx-commits] [PATCH] D150813: [libc++][docs] Add note about RFCs for significant changes

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 31 12:26:42 PDT 2023


This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG87acf6ddc73d: [libc++][docs] Add note about RFCs for significant changes (authored by ldionne).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150813/new/

https://reviews.llvm.org/D150813

Files:
  libcxx/docs/Contributing.rst


Index: libcxx/docs/Contributing.rst
===================================================================
--- libcxx/docs/Contributing.rst
+++ libcxx/docs/Contributing.rst
@@ -25,6 +25,15 @@
 that your feature is already being worked on, please consider chiming in instead
 of duplicating work!
 
+RFCs for significant user-affecting changes
+===========================================
+
+Before you start working on a change that can have significant impact on users of the library,
+please consider creating a RFC on `libc++'s Discourse forum <https://discourse.llvm.org/c/runtimes/libcxx>`__.
+This will ensure that you work in a direction that the project endorses and will ease reviewing your
+contribution as directional questions can be raised early. Including a WIP patch is not mandatory, but
+it can be useful to ground the discussion in something concrete.
+
 Pre-commit check list
 =====================
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150813.527161.patch
Type: text/x-patch
Size: 917 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230531/198b9045/attachment-0001.bin>


More information about the libcxx-commits mailing list