[libcxx-commits] [PATCH] D151654: [libc++] Transition all remaining generated tests to the new .gen format

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed May 31 12:21:04 PDT 2023


ldionne marked an inline comment as done.
ldionne added a comment.

In D151654#4384747 <https://reviews.llvm.org/D151654#4384747>, @Mordante wrote:

> Did we add documentation for this new feature?
> LGTM!

It is documented in `format.py` like we do for other types of tests.



================
Comment at: libcxx/include/__memory/allocator.h:101
 
-    _LIBCPP_CONSTEXPR_SINCE_CXX20 allocator() _NOEXCEPT = default;
+    _LIBCPP_HIDE_FROM_ABI _LIBCPP_CONSTEXPR_SINCE_CXX20 allocator() _NOEXCEPT = default;
 
----------------
Mordante wrote:
> Can this be landed separately?
Sure, will do!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151654/new/

https://reviews.llvm.org/D151654



More information about the libcxx-commits mailing list