[libcxx-commits] [PATCH] D151740: [libc++] Include "bits/alltypes.h" to provide mbstate_t when using musl libc

[Pengxuan Zheng via Phabricator via libcxx-commits]

pzheng added a comment.

In D151740#4384719 <https://reviews.llvm.org/D151740#4384719>, @Mordante wrote:

> In D151740#4384671 <https://reviews.llvm.org/D151740#4384671>, @pzheng wrote:
>
>> In D151740#4384276 <https://reviews.llvm.org/D151740#4384276>, @philnik wrote:
>>
>>> Please don't land libc++ patches until the libc++  group has approved.
>>
>> Oops, sorry for my ignorance, @philnik... I didn't know this rule existed for libc++ patch reviews. Thank you for educating me.
>
> In general in Phabricator when there are blocking reviewers you should wait on their approval.

Thanks for pointing it out, @Mordante. Again, my apologies for overlooking this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151740/new/

https://reviews.llvm.org/D151740