[libcxx-commits] [PATCH] D139147: [libc++][Android] Enable libc++ testing on Android

Wed May 31 09:08:14 PDT 2023

philnik added a comment.

In D139147#4382747 <https://reviews.llvm.org/D139147#4382747>, @rprichard wrote:

> I still haven't added anything to libcxx/utils/ci/buildkite-pipeline.yml. It's not clear to me whether that should be part of this patch, because there are several things that must happen first before CI tests will work:
>
> - I need to create a new docker image to add the Android stuff to it, and host it somewhere.
> - I need to setup a special buildbot on a VM somewhere that uses the new docker image.

You don't have to use a Docker image for a CI bot. Although it would be really nice, this is not a requirement, and if you want to do this it can still be done later.

> - There are a bunch of patches I have uploaded to Phabricator currently that are required to get tests running cleanly.

Any tests that fail can be marked `LIBCXX-ANDROID-FIXME` for now. Or do you mean something more general?

> - There are a few other fixes for tests that I don't have uploaded, because I'm not quite sure what we want to do (need to disable certain filesystem tests, and there are a couple of demangler problems involving floating-point).

Anything that doesn't work can be marked `LIBCXX-ANDROID-FIXME` for now. If it turns out these tests can't work on Android it can still be updated later.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139147/new/

https://reviews.llvm.org/D139147