[libcxx-commits] [PATCH] D150908: [libc++][ci] Use ccache in the jobs that build Clang

[Louis Dionne via Phabricator via libcxx-commits]

ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: libcxx/utils/ci/buildkite-pipeline-clang.yml:26
       # but with the number of jobs we run daily, this can result in thousands of GB of network I/O.
-      - "cmake -S llvm -B build -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install -DLLVM_ENABLE_PROJECTS=\"clang;compiler-rt\""
+      - "cmake -S llvm -B build -G Ninja -DCMAKE_CXX_COMPILER_LAUNCHER="ccache" -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=install -DLLVM_ENABLE_PROJECTS=\"clang;compiler-rt\""
       - "ninja -C build install-clang install-clang-resource-headers"
----------------
Mordante wrote:
> I've fixed this in https://reviews.llvm.org/rG4de9936fe0e31ceb817db1cdfc5dd4af2d44e01e
> I've created D151780 to validate whether this solves the build issue (https://buildkite.com/llvm-project/libcxx-ci/builds/25187)
Ah, thanks for the catch. Yeah this is an obvious mistake but I forgot to trigger the Clang CI to test this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150908/new/

https://reviews.llvm.org/D150908