[libcxx-commits] [PATCH] D132092: [2a/3][ASan][libcxx] std::deque annotations

Tacet via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 30 20:53:28 PDT 2023


AdvenamTacet added a comment.

@alexfh it's not by design. A `const_cast` is missing (or should I use `(void *)`?). We may add it in the very place where error happens or later before calling API, but type has to be changed here.

Working on the fix right now.

- I am going to add a const deque test.
- Add the `const_cast`, I believe it's the correct choice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132092/new/

https://reviews.llvm.org/D132092



More information about the libcxx-commits mailing list