[libcxx-commits] [PATCH] D139497: [libc++][Android] Bionic also includes + for NAN

[Ryan Prichard via Phabricator via libcxx-commits]

rprichard updated this revision to Diff 526857.
rprichard edited the summary of this revision.
rprichard added a comment.

Add a comment explaning why we don't just check `__ANDROID_API__`.

Also disable tests that convert a "NAN" string to long double on 64-bit targets. This bug was fixed in Android O. See https://android-review.googlesource.com/q/Id7d46ac2d8acb8770b5e8c445e87cfabfde6f111.

Remove the `__LIBCPP_TESTING_` prefix from the macros in favor of:

- `ANDROID_PRINTF_NAN_NO_SIGN`
- `ANDROID_BROKEN_STRTOLD_NAN`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139497/new/

https://reviews.llvm.org/D139497

Files:
  libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp
  libcxx/test/std/localization/locale.categories/category.numeric/locale.num.get/facet.num.get.members/get_long_double.pass.cpp
  libcxx/test/std/strings/string.conversions/stold.pass.cpp
  libcxx/utils/libcxx/test/features.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D139497.526857.patch
Type: text/x-patch
Size: 5486 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230531/0d8da481/attachment.bin>