[libcxx-commits] [PATCH] D144362: [libcxx] <experimental/simd> Add ABI tags, class template simd/simd_mask implementations. Add related simd traits and tests.

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik accepted this revision.
philnik added a comment.

The updated tests look really nice! Thanks!

You probably have to rebase on top of main to make the CI happy.



================
Comment at: libcxx/test/std/experimental/simd/simd.traits/is_abi_tag.pass.cpp:30-38
+  static_assert(!ex::is_abi_tag< _Tp >::value);
+  static_assert(!ex::is_abi_tag< ex::simd< _Tp, SimdAbi >>::value);
+  static_assert(!ex::is_abi_tag< ex::simd_mask< _Tp, SimdAbi >>::value);
+
+  static_assert(ex::is_abi_tag_v< SimdAbi >);
+
+  static_assert(!ex::is_abi_tag_v< _Tp >);
----------------
clang-format will be happy with this.


================
Comment at: libcxx/test/std/experimental/simd/test_utils.h:20-21
+
+using integral_no_bool_types =
+    types::concatenate_t<types::character_types, types::signed_integer_types, types::unsigned_integer_types>;
+using arithmetic_no_bool_types = types::concatenate_t<integral_no_bool_types, types::floating_point_types>;
----------------
This is just `integer_types`, right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144362/new/

https://reviews.llvm.org/D144362