[libcxx-commits] [PATCH] D148566: [libcxxabi] copy back std::string_view patches from LLVM

[Nick Desaulniers via Phabricator via libcxx-commits]

nickdesaulniers planned changes to this revision.
nickdesaulniers added inline comments.


================
Comment at: libcxxabi/src/demangle/ItaniumDemangle.h:3726
+        ScopedOverride<const char *> SaveFirst(First, &*ProtoSourceName.begin()),
+            SaveLast(Last, &*ProtoSourceName.end());
         Proto = parseBareSourceName();
----------------
egads...`libcxx/utils/ci/run-buildbot generic-debug-mode` is failing because:

llvm::StringView::end and std::string_view::end have different semantics! llvm::StringView::end  returns the last element, std::string_view::end returns 1 past the end element!

Let me fix that first downstream, then rebase this on top again.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148566/new/

https://reviews.llvm.org/D148566