[libcxx-commits] [PATCH] D151490: [libc++] Gives ignore external linkage.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue May 30 09:48:41 PDT 2023


Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: libcxx/include/tuple:1514-1516
 namespace {
   constexpr __ignore_t<unsigned char> ignore = __ignore_t<unsigned char>();
 } // namespace
----------------
philnik wrote:
> Is the anonymous namespace required? It should already have internal linkage, right?
I think it's not, but I want to keep the diff minimal.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151490/new/

https://reviews.llvm.org/D151490



More information about the libcxx-commits mailing list