[libcxx-commits] [PATCH] D149455: [libc++][test] Prefers the newer clang-tidy version.

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

I just spoke to Mark and he explained that this was necessary for the C++20 Modules work.

This is not policy-setting like in https://discourse.llvm.org/t/frc-versions-of-libc-clang-format-and-clang-tidy-dependencies/70953, this patch is basically a one-off required to unblock the modules work. If we end up deciding to use ToT clang-tidy after the RFC, then this patch would become permanent and not just a temporary workaround. Otherwise, it's just a temporary workaround since we require some recent clang-tidy features.

In light of this, I am OK with this patch but I do expect that after we land LLVM 17, we'll update the code base to reflect the consensus gained in the RFC (which might mean basically reverting this patch).



================
Comment at: libcxx/test/tools/clang_tidy_checks/CMakeLists.txt:8
 
-find_package(Clang 16)
+# TODO LLVM 17 prefer to sue teh stable release again instead of ToT.
+# libc++ normally prefers the use the last stable release instead of the ToT.
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149455/new/

https://reviews.llvm.org/D149455