[libcxx-commits] [PATCH] D151664: [lit] Add a method to lit.TestFormat to get the list of tests associated to a path

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added reviewers: jdenny, yln.
ldionne added a comment.

For context, the problem this solves is that libc++ now has a special kind of test called `.gen` tests. Those tests are basically a script that generates other Lit tests on the fly. This means that if I run for example `lit libcxx/test/libcxx/assertions/headers_declare_verbose_abort.gen.py`, I need Lit to actually understand that this corresponds to more than one test, i.e. all the tests generated in that `.gen.py` file.

I think this abstraction is actually what we want most of the time instead of `getTestsInDirectory` -- indeed, I looked at several custom test formats and most seemed to define `getTestsInDirectory` in a way that defining `getTestsForFilename` would have worked better, and then `getTestsInDirectory` would have been implemented generically on top of that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151664/new/

https://reviews.llvm.org/D151664