[libcxx-commits] [PATCH] D151475: [libc++][Modules] Add missing includes and exports

[Ian Anderson via Phabricator via libcxx-commits]

iana planned changes to this revision.
iana added a comment.

Still seeing some test failures.



================
Comment at: libcxx/include/__algorithm/pstl_backend.h:13
 #include <__algorithm/pstl_backends/cpu_backend.h>
+#include <__algorithm/pstl_backends/cpu_backends/backend.h>
 #include <__config>
----------------
iana wrote:
> philnik wrote:
> > This should be included through `<__algorithm/pstl_backends/cpu_backend.h>`.
> Oh, `<__algorithm/pstl_backends/cpu_backend.h>` doesn't include `<__algorithm/pstl_backends/cpu_backends/backend.h>`. Nothing does. I'll ad it there.
Err, typo in my find command. Each of the individual backends include `<__algorithm/pstl_backends/cpu_backends/backend.h>` but none of them export it. I guess they all need to.


================
Comment at: libcxx/include/__algorithm/sort.h:16
 #include <__algorithm/iterator_operations.h>
+#include <__algorithm/make_projected.h>
 #include <__algorithm/min_element.h>
----------------
philnik wrote:
> This is also never used in `sort.h`.
I think it is.

```
/Volumes/SoftwareDevelopment/Projects/llvm-project/build/generic-modules/include/c++/v1/__algorithm/sort.h:715:11: error: definition of '_ProjectedPred' must be imported from module 'std_private_algorithm_1.make_projected' before it is required
      if (__comp(*--__last, *__first))
          ^
/Volumes/SoftwareDevelopment/Projects/llvm-project/build/generic-modules/include/c++/v1/__algorithm/sort.h:855:8: note: in instantiation of function template specialization 'std::__introsort<std::_RangeAlgPolicy, std::_ProjectedPred<Less, Proj> &, T *, false>' requested here
  std::__introsort<_AlgPolicy,
       ^
/Volumes/SoftwareDevelopment/Projects/llvm-project/build/generic-modules/include/c++/v1/__algorithm/make_projected.h:31:8: note: definition here is not reachable
struct _ProjectedPred {
       ^
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151475/new/

https://reviews.llvm.org/D151475