[libcxx-commits] [PATCH] D151467: [libc++][NFC] Add additional test case for modules issue in Objective-C++

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri May 26 12:38:46 PDT 2023


ldionne marked an inline comment as done.
ldionne added inline comments.


================
Comment at: libcxx/test/libcxx/containers/sequences/vector/erase.modules.compile.pass.mm:12
+
+// REQUIRES: objective-c++
+
----------------
philnik wrote:
> Is this not implicitly checked through `.pass.mm`?
No, it's not. I thought it was better to have it explicitly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151467/new/

https://reviews.llvm.org/D151467



More information about the libcxx-commits mailing list