[libcxx-commits] [PATCH] D151490: [libc++] Gives ignore external linkage.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante created this revision.
Herald added a project: All.
Mordante updated this revision to Diff 526066.
Mordante added a comment.
Mordante published this revision for review.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

Rebased to fix CI.


A slightly different fix is in D144994 <https://reviews.llvm.org/D144994>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D151490

Files:
  libcxx/include/tuple


Index: libcxx/include/tuple
===================================================================
--- libcxx/include/tuple
+++ libcxx/include/tuple
@@ -1508,9 +1508,13 @@
     const __ignore_t& operator=(_Tp&&) const {return *this;}
 };
 
+#  if _LIBCPP_STD_VER >= 17
+inline constexpr __ignore_t<unsigned char> ignore = __ignore_t<unsigned char>();
+#  else
 namespace {
   constexpr __ignore_t<unsigned char> ignore = __ignore_t<unsigned char>();
 } // namespace
+#  endif
 
 template <class... _Tp>
 inline _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX14


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D151490.526066.patch
Type: text/x-patch
Size: 564 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230526/6c10bdb2/attachment.bin>