[libcxx-commits] [PATCH] D151573: [libc++][PSTL] Implement std::stable_sort

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/include/CMakeLists.txt:73
   __algorithm/pstl_any_all_none_of.h
   __algorithm/pstl_backend.h
   __algorithm/pstl_backends/cpu_backend.h
----------------
Missing docs for `__pstl_stable_sort` too.


================
Comment at: libcxx/include/__algorithm/pstl_backends/cpu_backend.h:23
 
   TODO: Document the parallel backend
 */
----------------
Missing docs?


================
Comment at: libcxx/include/__algorithm/pstl_backends/cpu_backends/serial.h:33
+template <class _RandomAccessIterator, class _Compare, class _LeafSort>
+_LIBCPP_HIDE_FROM_ABI void __parallel_stable_sort(
+    _RandomAccessIterator __first, _RandomAccessIterator __last, _Compare __comp, _LeafSort __leaf_sort, size_t = 0) {
----------------
Let's remove the `size_t = 0` unless it has a purpose.


================
Comment at: libcxx/include/__algorithm/pstl_backends/cpu_backends/thread.h:37
+_LIBCPP_HIDE_FROM_ABI void __parallel_stable_sort(
+    _RandomAccessIterator __first, _RandomAccessIterator __last, _Compare __comp, _LeafSort __leaf_sort, size_t = 0) {
+  __leaf_sort(__first, __last, __comp);
----------------
Same here for `= 0`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151573/new/

https://reviews.llvm.org/D151573