[libcxx-commits] [PATCH] D151304: [libcxx] [test] Fix the new alloc tests for Windows

Fri May 26 08:17:12 PDT 2023

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

Thanks for the diligence!

LGTM with a small comment.

================
Comment at: libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/new.size_nothrow.replace.indirect.pass.cpp:18
+// MSVC/vcruntime falls back from the nothrow array new to the nothrow
+// scalar new, instead of falling back on the throwing array new.
 // XFAIL: target={{.+}}-windows-msvc
----------------
mstorsjo wrote:
> FWIW, I reported this issue to vcruntime as https://developercommunity.visualstudio.com/t/vcruntime-nothrow-array-operator-new-fal/10373274.
Can you add a link to the bug report in the comment?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151304/new/

https://reviews.llvm.org/D151304