[libcxx-commits] [PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.
H. Vetinari via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu May 25 17:09:05 PDT 2023
h-vetinari added inline comments.
================
Comment at: libunwind/src/CMakeLists.txt:28-35
# See add_asm_sources() in compiler-rt for explanation of this workaround.
# CMake doesn't work correctly with assembly on AIX. Workaround by compiling
# as C files as well.
if((APPLE AND CMAKE_VERSION VERSION_LESS 3.19) OR
- (MINGW AND CMAKE_VERSION VERSION_LESS 3.17) OR
- (${CMAKE_SYSTEM_NAME} MATCHES "AIX"))
+ (MINGW AND CMAKE_VERSION VERSION_LESS 3.17))
set_source_files_properties(${LIBUNWIND_ASM_SOURCES} PROPERTIES LANGUAGE C)
----------------
Shouldn't it be possible to remove that entire block (as it only fires for CMake <3.20)?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151344/new/
https://reviews.llvm.org/D151344
More information about the libcxx-commits
mailing list