[libcxx-commits] [PATCH] D151475: [libc++][Modules] Add missing includes and exports

[Ian Anderson via Phabricator via libcxx-commits]

iana added inline comments.


================
Comment at: libcxx/include/__locale_dir/locale_base_api/bsd_locale_fallbacks.h:16
 
+#include <__locale>
 #include <__locale_dir/locale_base_api/locale_guard.h>
----------------
philnik wrote:
> `bsd_locale_fallbacks.h` should probably not be part of the module. This might not compile on all platforms. 
It has to be part of the module because it's included by <locale>. But it doesn't compile on all platforms, so it's a textual header so that it only gets used if <locale> actually includes it.


================
Comment at: libcxx/include/__mdspan/extents.h:22
 #include <__config>
+#include <__fwd/span.h>
 #include <__type_traits/common_type.h>
----------------
philnik wrote:
> `<span>` is already included. There shouldn't be a need to include a forward declaration.
That's what I thought, but I was still getting an error without it. Let me try again, I found an issue where some modules were exporting modules that they didn't include in the first place, and that seems to make clang mad.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151475/new/

https://reviews.llvm.org/D151475