[libcxx-commits] [PATCH] D144394: [libc++] Forward to std::{, w}memchr in std::find

[Thurston Dang via Phabricator via libcxx-commits]

thurston added a comment.

In D144394#4373206 <https://reviews.llvm.org/D144394#4373206>, @philnik wrote:

> In D144394#4373150 <https://reviews.llvm.org/D144394#4373150>, @thurston wrote:
>
>> I think this might have broken one of the sanitizer buildbots:
>>
>> https://lab.llvm.org/buildbot/#/builders/37/builds/22340
>>
>>   + diff -u /b/sanitizer-x86_64-linux/build/llvm-project/compiler-rt/lib/sanitizer_common/symbolizer/scripts/global_symbols.txt undefined.new
>>   +wmemchr U
>>   + echo 'Failed: unexpected symbols'
>>
>> (it might just need to have that line added?)
>
> Yeah, that looks like a compiler-rt thing. I guess they check which symbols they rely on (and apparently now they rely on ẁmemchr`). Given that `wmemcpy`, `wmemmove` and `wmemset` are also listed there, it's probably fine to add `wmemchr`.

Thanks Phil! I've added it in D151484 <https://reviews.llvm.org/D151484>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144394/new/

https://reviews.llvm.org/D144394