[libcxx-commits] [PATCH] D151475: [libc++][Modules] Add missing includes and exports

[Nikolas Klauser via Phabricator via libcxx-commits]

philnik requested changes to this revision.
philnik added a comment.
This revision now requires changes to proceed.

There seem to be a lot of false-positives from the module map change.



================
Comment at: libcxx/include/__algorithm/copy.h:16
 #include <__config>
+#include <__iterator/iterator_with_data.h>
 #include <__iterator/segmented_iterator.h>
----------------
This include is wrong. `__iterator_with_data` isn't used in this file.


================
Comment at: libcxx/include/__algorithm/copy_backward.h:16
 #include <__config>
+#include <__iterator/iterator_with_data.h>
 #include <__iterator/segmented_iterator.h>
----------------
Same here.


================
Comment at: libcxx/include/__algorithm/pstl_any_all_none_of.h:20
 #include <__type_traits/remove_cvref.h>
+#include <__utility/forward.h>
+#include <__utility/move.h>
----------------
Same here.


================
Comment at: libcxx/include/__algorithm/pstl_backend.h:13
 #include <__algorithm/pstl_backends/cpu_backend.h>
+#include <__algorithm/pstl_backends/cpu_backends/backend.h>
 #include <__config>
----------------
This should be included through `<__algorithm/pstl_backends/cpu_backend.h>`.


================
Comment at: libcxx/include/__algorithm/pstl_fill.h:21
 #include <__type_traits/remove_cvref.h>
+#include <__utility/forward.h>
+#include <__utility/move.h>
----------------
Same here.


================
Comment at: libcxx/include/__algorithm/pstl_find.h:21
 #include <__type_traits/remove_cvref.h>
+#include <__utility/forward.h>
+#include <__utility/move.h>
----------------
and here.


================
Comment at: libcxx/include/__algorithm/sort.h:16
 #include <__algorithm/iterator_operations.h>
+#include <__algorithm/make_projected.h>
 #include <__algorithm/min_element.h>
----------------
This is also never used in `sort.h`.


================
Comment at: libcxx/include/__locale_dir/locale_base_api/bsd_locale_fallbacks.h:16
 
+#include <__locale>
 #include <__locale_dir/locale_base_api/locale_guard.h>
----------------
`bsd_locale_fallbacks.h` should probably not be part of the module. This might not compile on all platforms. 


================
Comment at: libcxx/include/__mdspan/extents.h:22
 #include <__config>
+#include <__fwd/span.h>
 #include <__type_traits/common_type.h>
----------------
`<span>` is already included. There shouldn't be a need to include a forward declaration.


================
Comment at: libcxx/include/__random/discrete_distribution.h:14
 #include <__config>
+#include <__iterator/wrap_iter.h>
 #include <__random/is_valid.h>
----------------
This is also never used here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151475/new/

https://reviews.llvm.org/D151475