[libcxx-commits] [PATCH] D151375: [libc++][PSTL] Implement std::merge

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu May 25 09:05:56 PDT 2023


philnik created this revision.
Herald added a reviewer: ldionne.
Herald added a project: All.
philnik updated this revision to Diff 525360.
philnik added a comment.
philnik updated this revision to Diff 525633.
ldionne published this revision for review.
Herald added subscribers: libcxx-commits, pcwang-thead.
Herald added a project: libc++.
Herald added a reviewer: libc++.

Add tests


philnik added a comment.

Generate files



================
Comment at: libcxx/include/__algorithm/pstl_backends/cpu_backend.h:22
   void __cancel_execution();
 
   TODO: Document the parallel backend
----------------
I think you forgot to document the new customization point here and also the `__pstl` one.


================
Comment at: libcxx/include/__algorithm/pstl_backends/cpu_backends/merge.h:28
+          class _ForwardIterator2,
+          class _ForwatdOutIterator,
+          class _Comp>
----------------



Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D151375

Files:
  libcxx/include/CMakeLists.txt
  libcxx/include/__algorithm/pstl_backends/cpu_backend.h
  libcxx/include/__algorithm/pstl_backends/cpu_backends/merge.h
  libcxx/include/__algorithm/pstl_backends/cpu_backends/serial.h
  libcxx/include/__algorithm/pstl_backends/cpu_backends/thread.h
  libcxx/include/__algorithm/pstl_merge.h
  libcxx/include/__pstl/internal/algorithm_impl.h
  libcxx/include/__pstl/internal/glue_algorithm_impl.h
  libcxx/include/__pstl/internal/parallel_backend_serial.h
  libcxx/include/algorithm
  libcxx/test/libcxx/private_headers.verify.cpp
  libcxx/test/std/algorithms/alg.sorting/alg.merge/pstl.merge.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D151375.525633.patch
Type: text/x-patch
Size: 21540 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20230525/9ca42b9f/attachment-0001.bin>


More information about the libcxx-commits mailing list