[libcxx-commits] [PATCH] D151267: mdspan: implement layout_right

Christian Trott via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu May 25 08:25:21 PDT 2023


crtrott added inline comments.


================
Comment at: libcxx/include/__mdspan/layouts.h:34
+// Will be implemented with follow on revision
+#  if 0
+// Layout policy with a mapping which corresponds to FORTRAN-style array layouts
----------------
EricWF wrote:
> I don't like adding commented or ifdefed out code like this.
> 
> Maybe just leave a comment declaration.
Yeah thats fine I can do that. Just gonna wait for a bit more feedback before submitting a revision.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151267/new/

https://reviews.llvm.org/D151267



More information about the libcxx-commits mailing list