[libcxx-commits] [PATCH] D151244: [libc++][NFC] Remove regex matchers for static_assert in .verify tests

Hristo Hristov via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu May 25 00:25:13 PDT 2023


H-G-Hristov added inline comments.


================
Comment at: libcxx/test/libcxx/atomics/atomics.types.operations/atomics.types.operations.req/atomic_fetch_add.verify.cpp:49
     volatile std::atomic<void (*)(int)> fun;
-    // expected-error-re@*:* {{{{(static_assert|static assertion)}} failed due to requirement '!is_function<void (int)>::value'{{.*}}Pointer to function isn't allowed}}
+    // expected-error@*:* {{static assertion failed due to requirement '!is_function<void (int)>::value'{{.*}}Pointer to function isn't allowed}}
     std::atomic_fetch_add(&fun, 0);
----------------
I'm compiling with Apple Clang 14.0.3 which returns "static_assert" but the CI returns "static assertion". I was wondering how to handle that in my tests. I guess that's the way. Wouldn't this change make these tests unusable on Apple Clang 14.0.3 which is supposed to be Clang 15?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151244/new/

https://reviews.llvm.org/D151244



More information about the libcxx-commits mailing list